Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix noop_update_total metric in indexing stats cannot be updated by bulk API #11485

Merged
merged 11 commits into from
Jan 11, 2024
Merged

Fix noop_update_total metric in indexing stats cannot be updated by bulk API #11485

merged 11 commits into from
Jan 11, 2024

Conversation

gaobinlong
Copy link
Collaborator

@gaobinlong gaobinlong commented Dec 6, 2023 •
edited
Loading

Description

Same to the update API, we should update the noop_update_total metric in indexing stats when there's a noop update operation happened in bulk.

Related Issues

#9857

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Failing checks are inspected and point to the corresponding known issue(s) (See: Troubleshooting Failing Builds)
  • Commits are signed per the DCO using --signoff
  • Commit changes are listed out in CHANGELOG.md file (See: Changelog)
  • Public documentation issue/PR created

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

@gaobinlong
Fix noop_update_total metric in indexing stats cannot be updated by b…
9323b74 
…ulk API

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@gaobinlong
Modify change log
04a8843 
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 6, 2023 •
edited
Loading

Compatibility status:

Checks if related components are compatible with change acefff7

Incompatible components

Skipped components

Compatible components

Compatible components: [https://github.com/opensearch-project/security-analytics.git, https://github.com/opensearch-project/security.git, https://github.com/opensearch-project/observability.git, https://github.com/opensearch-project/job-scheduler.git, https://github.com/opensearch-project/sql.git, https://github.com/opensearch-project/opensearch-oci-object-storage.git, https://github.com/opensearch-project/notifications.git, https://github.com/opensearch-project/custom-codecs.git, https://github.com/opensearch-project/neural-search.git, https://github.com/opensearch-project/ml-commons.git, https://github.com/opensearch-project/index-management.git, https://github.com/opensearch-project/geospatial.git, https://github.com/opensearch-project/cross-cluster-replication.git, https://github.com/opensearch-project/asynchronous-search.git, https://github.com/opensearch-project/reporting.git, https://github.com/opensearch-project/k-nn.git, https://github.com/opensearch-project/anomaly-detection.git, https://github.com/opensearch-project/common-utils.git, https://github.com/opensearch-project/performance-analyzer-rca.git, https://github.com/opensearch-project/alerting.git, https://github.com/opensearch-project/performance-analyzer.git]

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 7, 2023

❕ Gradle check result for 386399c: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@codecov Codecov
Copy link

codecov bot commented Dec 7, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5ccd134) 71.30% compared to head (acefff7) 71.32%.
Report is 44 commits behind head on main.

Additional details and impacted files 
@@             Coverage Diff              @@
##               main   #11485      +/-   ##
============================================
+ Coverage     71.30%   71.32%   +0.02%     
- Complexity    59157    59200      +43     
============================================
  Files          4906     4906              
  Lines        278198   278199       +1     
  Branches      40422    40422              
============================================
+ Hits         198358   198436      +78     
+ Misses        63414    63281     -133     
- Partials      16426    16482      +56

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gaobinlong
Copy link
Collaborator Author

org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing is flaky, there's an issue tracking it.

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 26de91e: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gaobinlong
Small change to rerun gradle check
21559f8 
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 21559f8: UNSTABLE

  • TEST FAILURES:
      2 org.opensearch.remotestore.RemoteIndexPrimaryRelocationIT.testPrimaryRelocationWhileIndexing
      1 org.opensearch.remotestore.CreateRemoteIndexIT.testDefaultRemoteStoreNoUserOverride

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 1a589b6: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.cluster.allocation.ClusterRerouteIT.testDelayWithALargeAmountOfShards

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@github-actions GitHub Actions
Copy link
Contributor

❕ Gradle check result for 9e4c674: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.repositories.azure.AzureBlobContainerRetriesTests.testWriteLargeBlob

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gaobinlong
merge main
acefff7 
Signed-off-by: Gao Binlong <gbinlong@amazon.com>
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 2, 2024

❕ Gradle check result for acefff7: UNSTABLE

  • TEST FAILURES:
      1 org.opensearch.smoketest.SmokeTestMultiNodeClientYamlTestSuiteIT.test {yaml=pit/10_basic/Delete all}

Please review all flaky tests that succeeded after retry and create an issue if one does not already exist to track the flaky failure.

@gaobinlong
Copy link
Collaborator Author

Can this PR be merged now? Thanks!

@deshsidd
Copy link
Contributor

Thanks, LGTM

@deshsidd
Copy link
Contributor

Looks like builds are passing now. Will require one maintainers approval @dblock @reta @msfroh @peternied @andrross

@peternied peternied added the backport 2.x Backport to 2.x branch label Jan 11, 2024
@peternied peternied merged commit a90b6b6 into opensearch-project:main Jan 11, 2024
34 of 35 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jan 11, 2024
@github-actions
Fix noop_update_total metric in indexing stats cannot be updated by b…
b061b81 
…ulk API (#11485)

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
(cherry picked from commit a90b6b6)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot opensearch-trigger-bot bot mentioned this pull request Jan 11, 2024
Merged
kotwanikunal pushed a commit that referenced this pull request Jan 12, 2024
@opensearch-trigger-bot @github-actions
Fix noop_update_total metric in indexing stats cannot be updated by b…
d73b133 
…ulk API (#11485) (#11865)

(cherry picked from commit a90b6b6)

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@gaobinlong gaobinlong mentioned this pull request Jan 18, 2024
Merged
8 tasks
@BrewTestBot BrewTestBot mentioned this pull request Feb 21, 2024
Merged
rayshrey pushed a commit to rayshrey/OpenSearch that referenced this pull request Mar 18, 2024
@gaobinlong @rayshrey
Fix noop_update_total metric in indexing stats cannot be updated by b…
e0efa43 
…ulk API (opensearch-project#11485)

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
shiv0408 pushed a commit to Gaurav614/OpenSearch that referenced this pull request Apr 25, 2024
@gaobinlong @shiv0408
Fix noop_update_total metric in indexing stats cannot be updated by b…
f2f61ff 
…ulk API (opensearch-project#11485)

Signed-off-by: Gao Binlong <gbinlong@amazon.com>
Signed-off-by: Shivansh Arora <hishiv@amazon.com>
@r1walz r1walz mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankitkala ankitkala ankitkala approved these changes

@peternied peternied peternied approved these changes

@deshsidd deshsidd deshsidd approved these changes

@r1walz r1walz r1walz approved these changes

@abbashus abbashus Awaiting requested review from abbashus

@adnapibar adnapibar Awaiting requested review from adnapibar

@anasalkouz anasalkouz Awaiting requested review from anasalkouz anasalkouz is a code owner

@andrross andrross Awaiting requested review from andrross andrross is a code owner

@Bukhtawar Bukhtawar Awaiting requested review from Bukhtawar Bukhtawar is a code owner

@CEHENKLE CEHENKLE Awaiting requested review from CEHENKLE CEHENKLE is a code owner

@dblock dblock Awaiting requested review from dblock dblock is a code owner

@dbwiddis dbwiddis Awaiting requested review from dbwiddis dbwiddis is a code owner

@dreamer-89 dreamer-89 Awaiting requested review from dreamer-89

@gbbafna gbbafna Awaiting requested review from gbbafna gbbafna is a code owner

@kartg kartg Awaiting requested review from kartg

@kotwanikunal kotwanikunal Awaiting requested review from kotwanikunal kotwanikunal is a code owner

@mch2 mch2 Awaiting requested review from mch2 mch2 is a code owner

@msfroh msfroh Awaiting requested review from msfroh msfroh is a code owner

@nknize nknize Awaiting requested review from nknize nknize is a code owner

@owaiskazi19 owaiskazi19 Awaiting requested review from owaiskazi19 owaiskazi19 is a code owner

@reta reta Awaiting requested review from reta reta is a code owner

@Rishikesh1159 Rishikesh1159 Awaiting requested review from Rishikesh1159 Rishikesh1159 is a code owner

@ryanbogan ryanbogan Awaiting requested review from ryanbogan

@sachinpkale sachinpkale Awaiting requested review from sachinpkale sachinpkale is a code owner

@saratvemulapalli saratvemulapalli Awaiting requested review from saratvemulapalli saratvemulapalli is a code owner

@setiah setiah Awaiting requested review from setiah

@shwetathareja shwetathareja Awaiting requested review from shwetathareja shwetathareja is a code owner

@sohami sohami Awaiting requested review from sohami sohami is a code owner

@tlfeng tlfeng Awaiting requested review from tlfeng

@VachaShah VachaShah Awaiting requested review from VachaShah VachaShah is a code owner

Assignees
No one assigned
Labels
backport 2.x Backport to 2.x branch
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@gaobinlong @deshsidd @ankitkala @peternied @r1walz